https://bugzilla.redhat.com/show_bug.cgi?id=1293100 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #22 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Roman Tsisyk from comment #21) > Changelog: > > - Implement proper support of multi-instance management using systemd > https://github.com/tarantool/tarantool/blob/ > e15bc621f1bca24c1ee61405f8511369f9489716/README.systemd.md > - Enable hardened builds and -debuginfo > - Add coreutils, make and sed to BuildRequires > - Drop binutils-devel, zlib-devel dependencies > - Drop all legacy stuff > > Current problems: > > 1. > tarantool.x86_64: E: non-standard-dir-perm /var/log/tarantool 750 > tarantool.x86_64: E: non-standard-dir-perm /var/lib/tarantool 750 > I use 0750 to allow read database files only for members of tarantool group. > > Please help me to resolve this problem. I don't think it's a problem. The permissions look reasonable. > 2. tarantool-devel.x86_64: W: no-documentation > Documentation for /usr/inc.ude/tarantool/module.h is provided on the > web-site: > http://tarantool.org/doc/reference/capi.html > I can generate a man page from Doxygen, but does it make sense? No, documentation is nice, but it certainly isn't required. Basically the rule is that if upstream provides documentation that can be built without unreasonable effort, it should be included. > 3. tar.gz contains some JS crap in doc/sphinx > => Upstream's buildbot will be fixed soonto generate proper tarballs. The only thing which is forbidden, is non-distributable sources. Including some javascript that sphinx uses is allowed, even if a bit messy. > 4. I'm working on enabling %check > Tarantool has the extensive test suite, so I'm trying to get test-run.py > working under mock on all platforms. > https://travis-ci.org/tarantool/tarantool/jobs/107191725#L1187 It would be > nice to have an access to some Fedora/RHEL armhf box to check mock... See https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers. You can use those without asking anybody. There are also PPC machines, but I think you have to ask for access. Review: - license is acceptable (BSD) - license file is present, %license is used - latest version - builds and installs OK - scriptlets look OK (*) - build and requires look OK - description and summary and package name are OK - rpmlint only has false positives Package is APPROVED. (*) The %post script currently fails, but this seems to be a bug in systemd in F23. It doesn't matter much for now because it's unlikely that anyone will be using presets to enable tarantool instances in the near future. I'll try to get this fixed upstream in systemd. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review