https://bugzilla.redhat.com/show_bug.cgi?id=1279787 Pavel Alexeev <pahan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |pahan@xxxxxxxxxxxxx Flags| |fedora-review+ --- Comment #11 from Pavel Alexeev <pahan@xxxxxxxxxxxxx> --- Package Review ============== Legend: [+] = Pass, [!] = Fail, [x] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [+]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [+]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 76 files have unknown license. Detailed output of licensecheck in /home/pasha/SOFT/FEDORA/reviews/python-csvkit/1/1279787-python- csvkit/licensecheck.txt [+]: License file installed when any subpackage combination is installed. [+]: Package contains no bundled libraries without FPC exception. [+]: Changelog in prescribed format. [+]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [+]: Package uses nothing in %doc for runtime. [+]: Package consistently uses macros (instead of hard-coded directory names). [+]: Package is named according to the Package Naming Guidelines. [+]: Package does not generate any conflict. [+]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [+]: Requires correct, justified where necessary. [+]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [+]: Package is not known to require an ExcludeArch tag. [+]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 6 files. [+]: Package complies to the Packaging Guidelines [+]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [+]: Package installs properly. [!]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Several warnings about line endings. Some in examples may be leaved as is because it intentional. But spurious-executable-perm /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/VROUTFSJ.TXt should be changed. python-csvkit-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-csvkit-doc/html/.buildinfo I think have no worth packaging. python-csvkit-doc.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/VROUTFSJ.TXt Please correct it where possible: https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding [+]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [+]: Package requires other packages for directories it uses. [+]: Package must own all directories that it creates. [+]: Package does not own files or directories owned by other packages. [+]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [+]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [+]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [+]: Macros in Summary, %description expandable at SRPM build time. [+]: Dist tag is present. [+]: Package does not contain duplicates in %files. [+]: Permissions on files are set properly. [+]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [+]: Package is named using only allowed ASCII characters. [+]: Package does not use a name that already exists. [+]: Package is not relocatable. [+]: Sources used to build the package match the upstream source, as provided in the spec URL. [+]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [+]: File names are valid UTF-8. [+]: Packages must not store files under /srv, /opt or /usr/local Python: [+]: Python eggs must not download any dependencies during the build process. [+]: A package which is used by another package via an egg interface should provide egg info. [+]: Package meets the Packaging Guidelines::Python [+]: Package contains BR: python2-devel or python3-devel [+]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [+]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [+]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [+]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-csvkit , python3-csvkit , python-csvkit-doc [?]: Package functions as described. [+]: Latest version is packaged. [+]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. correct-requires.patch has no links or comments [+]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [+]: Package should compile and build into binary rpms on all supported architectures. [+]: %check is present and all tests pass. [+]: Packages should try to preserve timestamps of original installed files. [+]: Sources can be downloaded from URI in Source: tag [+]: Reviewer should test that the package builds in mock. [+]: Buildroot is not present [+]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [+]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [+]: SourceX is a working URL. [+]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-csvkit-0.9.1-4.gitbf18815.fc23.noarch.rpm python3-csvkit-0.9.1-4.gitbf18815.fc23.noarch.rpm python-csvkit-doc-0.9.1-4.gitbf18815.fc23.noarch.rpm python-csvkit-0.9.1-4.gitbf18815.fc23.src.rpm python2-csvkit.noarch: W: no-manual-page-for-binary csvgrep-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary in2csv-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvsort-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary in2csv-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvsort-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvstack-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvstat-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary sql2csv-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvlook-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvjson-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvjoin-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvformat-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvclean-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvpy-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvformat-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvcut-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvlook-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvstack-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvjson-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvstat-2 python2-csvkit.noarch: W: no-manual-page-for-binary sql2csv-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvgrep-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvpy-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvsql-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvsql-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvclean-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvcut-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvjoin-2.7 python3-csvkit.noarch: W: no-manual-page-for-binary in2csv-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvjson-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvstack-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvformat-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvformat-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvcut-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvsort-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvlook-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvsql-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvgrep-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvjoin-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvstat-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvpy-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvclean-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvjoin-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvsort-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvstat-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvgrep-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvpy-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary in2csv-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvlook-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvjson-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvclean-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvstack-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvcut-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary sql2csv-3 python3-csvkit.noarch: W: no-manual-page-for-binary sql2csv-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvsql-3.4 python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/FY09_EDU_Recipients_by_State.csv python-csvkit-doc.noarch: W: file-not-utf8 /usr/share/doc/python-csvkit-doc/examples/test_latin1.csv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/determination_schema.csv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/event-notification-rpt-lastmonth.txt python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2010/census2010_geo_schema.csv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/usgeo_excerpt.upl python-csvkit-doc.noarch: W: spurious-executable-perm /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/VROUTFSJ.TXt python-csvkit-doc.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/VROUTFSJ.TXt python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/html/objects.inv python-csvkit-doc.noarch: W: file-not-utf8 /usr/share/doc/python-csvkit-doc/html/objects.inv python-csvkit-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-csvkit-doc/html/.buildinfo python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/usgeo.upl python-csvkit-doc.noarch: W: file-not-utf8 /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/usgeo.upl python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/Datagov_FY10_EDU_recp_by_State.csv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/mac_newlines.csv 4 packages and 0 specfiles checked; 1 errors, 70 warnings. Rpmlint (installed packages) ---------------------------- python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/event-notification-rpt-lastmonth.txt python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/usgeo_excerpt.upl python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/determination_schema.csv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/usgeo.upl python-csvkit-doc.noarch: W: file-not-utf8 /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/usgeo.upl python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/FY09_EDU_Recipients_by_State.csv python-csvkit-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-csvkit-doc/html/.buildinfo python-csvkit-doc.noarch: W: file-not-utf8 /usr/share/doc/python-csvkit-doc/examples/test_latin1.csv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/html/objects.inv python-csvkit-doc.noarch: W: file-not-utf8 /usr/share/doc/python-csvkit-doc/html/objects.inv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/mac_newlines.csv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2010/census2010_geo_schema.csv python-csvkit-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/Datagov_FY10_EDU_recp_by_State.csv python-csvkit-doc.noarch: W: spurious-executable-perm /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/VROUTFSJ.TXt python-csvkit-doc.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/python-csvkit-doc/examples/realdata/census_2000/VROUTFSJ.TXt python3-csvkit.noarch: W: no-manual-page-for-binary csvpy-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary in2csv-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvjoin-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvjson-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvclean-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvsort-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvsort-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvlook-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvstack-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvformat-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary sql2csv-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvlook-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvformat-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvsql-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvstack-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvjoin-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvcut-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvstat-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvpy-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvgrep-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvclean-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvcut-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary sql2csv-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvgrep-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary csvsql-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvjson-3 python3-csvkit.noarch: W: no-manual-page-for-binary csvstat-3.4 python3-csvkit.noarch: W: no-manual-page-for-binary in2csv-3.4 python2-csvkit.noarch: W: no-manual-page-for-binary sql2csv-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvclean-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvgrep-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvsql-2 python2-csvkit.noarch: W: no-manual-page-for-binary in2csv-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvjoin-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvlook-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvformat-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvjson-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvformat-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvpy-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvpy-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvstat-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvlook-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvsort-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvjson-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvclean-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvgrep-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary in2csv-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvstack-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvsort-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvsql-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvjoin-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvstat-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary sql2csv-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvcut-2 python2-csvkit.noarch: W: no-manual-page-for-binary csvcut-2.7 python2-csvkit.noarch: W: no-manual-page-for-binary csvstack-2.7 3 packages and 0 specfiles checked; 1 errors, 70 warnings. Requires -------- python-csvkit-doc (rpmlib, GLIBC filtered): python3-csvkit (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-dateutil python3-openpyxl python3-six python3-sqlalchemy python3-xlrd python2-csvkit (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-dateutil python-enum34 python-six python-sqlalchemy python-xlrd python2-dbf python2-openpyxl Provides -------- python-csvkit-doc: python-csvkit-doc python3-csvkit: python3-csvkit python2-csvkit: python-csvkit python2-csvkit Source checksums ---------------- https://github.com/onyxfish/csvkit/archive/bf18815796a306d34171422f1445323b526ba14f/csvkit-bf18815796a306d34171422f1445323b526ba14f.tar.gz : CHECKSUM(SHA256) this package : 80e2613c6f7969f4f1ad61ea506196da3afa74909550a5b0b37eea9c0444706b CHECKSUM(SHA256) upstream package : 80e2613c6f7969f4f1ad61ea506196da3afa74909550a5b0b37eea9c0444706b Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-23-x86_64 -b 1279787 Buildroot used: fedora-23-x86_64 Active plugins: Python, Generic, Shell-api, Perl Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Conclusion: Please add comment with link for patch and solve minor rpmlint warnings where possible. No critical issues found. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review