[Bug 1299179] Review Request: editorconfig - tools for text editors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1299179



--- Comment #4 from Andy Lutomirski <luto@xxxxxxxxxx> ---
Comments:

You have the ldconfig scriptlets attached to the wrong package -- they belong
on -libs.

This is wrong:

%package -n %{name}-libs
Summary:    Shared libraries for EditorConfig
Group:        Documentation
Requires:    %{name}%{?_isa} = %{version}-%{release}

The main package should require the -libs package (which rpm will do for you by
figuring it out from DT_NEEDED), not the other way around.  In particular, your
current variant breaks multilib installs.

If you fix that, please move the %license to -libs.  You may need it in -doc,
too.

fedora-review is chugging away at this, and I may have more comments when it
finishes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]