https://bugzilla.redhat.com/show_bug.cgi?id=1304882 --- Comment #3 from awilliam@xxxxxxxxxx <awilliam@xxxxxxxxxx> --- 1. Good point on the Requires(post), I'm not entirely sure why it's there; I don't see why os-autoinst would be required for %post, unless it's somehow needed for database creation (I don't see why). I'll ask. 2. The tests have some deps that are not yet packaged. The test deletion comes from the openSUSE spec, where they do run the tests (see the note about staying in sync with upstream where possible). 3. I don't think it's 100% consistent, but yeah, I prefer %{} style. I'll have to check if it makes the diff to upstream uglier, but I think it might be OK to change. 4. Hmm, yep, especially the one which uses the macro in one line and hard codes the location in the next :) I think I agree, I will change that. Thanks! 5. Yeah, I was thinking of that too. It doesn't really need to be a subpackage, but it wouldn't hurt anything, and at least probably we shouldn't hard require Apache. I'm not very familiar with nginx config so would need someone to contribute it, but it'd be great to have a subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review