Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: olpc-utils - various utilities used by OLPC but not packaged anywhere else https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244908 ------- Additional Comments From pertusus@xxxxxxx 2007-06-20 16:25 EST ------- This package isn't acceptable even with the changes asked above. %{_datadir}/olpc/ is unowned, this is a blocker. Also I think that the macro olpc_utils_version is useless The optflags are not used during compilation. This is ablocker. The Makefile doesn't allow to use the macros like %{_datadir} and so on, so I think that the best would be to do the install 'by hand', like install -d %{buildroot}%{_datadir}/olpc/keycodes .... Another reason would be because there is no possibility to keep the timestamp during install, like install -p --mode=0664 olpc-evdev %{buildroot}%{_datadir}/olpc/keycodes -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review