https://bugzilla.redhat.com/show_bug.cgi?id=1300070 Antonio Trande <anto.trande@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #26 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Colin Macdonald from comment #24) > Thank you for the review! > > 1. I hope I have addressed your comments, except for the rpmlint warnings: > > >> octave-doctest.x86_64: W: no-documentation > > Noted above: all doc files are needed for package to function correctly thus > not marked %doc. > > >> octave-doctest.x86_64: W: dangerous-command-in-%preun mv > > I think this is from the .macro file > > > 2. I don't really understand the __exclude_exclude: in particular, is it > correct to place it at the top of the file? > It's provided for by guidelines for Octave packages: http://fedoraproject.org/wiki/Packaging:Octave#Arch_specific_Octave_spec_template > > 3. Updated files: > > Spec URL: https://cbm.fedorapeople.org/octave-doctest.spec > SRPM URL: https://cbm.fedorapeople.org/octave-doctest-0.4.1-3.fc23.src.rpm > > Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review