https://bugzilla.redhat.com/show_bug.cgi?id=1298251 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: $ diff -u shrinkpdf.spec{.old,} --- shrinkpdf.spec.old 2016-01-13 16:29:09.000000000 +0100 +++ shrinkpdf.spec 2016-02-03 11:58:37.000000000 +0100 @@ -12,13 +12,13 @@ BuildArch: noarch Requires: ghostscript-core +Requires: coreutils %description A simple wrapper around Ghostscript to shrink PDFs (as in reduce -filesize) under Linux. Inspired by some code found in an OpenOffice -Python script (I think). The script feeds a PDF through Ghostscript, -which performs lossy recompression by such methods as downsampling -the images to 72dpi. The result should be (but not always is) a much +file size) under Linux. The script feeds a PDF through Ghostscript, +which performs lossy recompression by such methods own as downsampling +the images to 72 DPI. The result should be (but not always is) a much smaller file. > TODO: I would improve the description a little bit. I would spell "filesize" > as two words "file size". I think the second sentence "Inspired by some code > found in an OpenOffice Python script (I think)" is irrelevant and I would > remove it. Also I think "72dpi" is spelled wrongly. I'd write it as "72 DPI". TODO: I think an "own" word slipped into your text this time. > FIX: Build-require "coreutils" (shrinkpdf.spec:30). Not addressed. Please add the build-require. > FIX: Run-require "coreutils" because the script executes "cp", "wc", and > "cut" programs. $ rpm -q --requires -p ../RPMS/noarch/shrinkpdf-0-1.fc24.noarch.rpm | sort -f | uniq -c 1 /bin/sh 1 coreutils 1 ghostscript-core 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=12802729). Ok. Please add build-dependency on coreutils before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review