[Bug 1298251] Review Request: shrinkpdf - Simple wrapper around Ghostscript to shrink PDFs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1298251



--- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> ---
(In reply to Raphael Groner from comment #3)
> thanks for your hints. I do not see any blockers. Please approve the package.
> 
Good package is also mark of the reviewer and I will no pass package with these
simple to fix mistakes. Please correct the issues I marked as `FIX' and then I
will approve this package.

> Spelling errors
> They do not harm with packaging in general, therefore marked as warnings.
>
Though if spotted they should be fixed. Especially the "filesize" is not an
English word.

> coreutils
> That package can be assumed to be installed in every working system.
> Otherwise, we would have to add iit as dependency to every other packages as
> well. It's always present in a fresh mock build environment and so also on
> koji.

We have to add it to every package that needs it.
<https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRequires_2>.
There is no exceptions list anymore.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]