Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Business-CreditCard - Validate/generate credit card checksums/names https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244947 ------- Additional Comments From devrim@xxxxxxxxxxxxxxxxx 2007-06-20 15:02 EST ------- - MUST: OK, the package is named according to the Package Naming Guidelines. - MUST: OK: The package must meet the Packaging Guidelines. - MUST: OK, the spec file name matches the base package %{name}, in the format %{name}.spec - MUST: OK, license issue (see must fixes) - MUST: OK, tarball does not include license file. - MUST: OK, the spec file is written in American English. - MUST: OK, the spec file for the package is legible. - MUST: OK, source file matches the upstream source: 2d532583fbd58561f7f46f914cdf4510 Business-CreditCard-0.30.tar.gz - MUST: OK, package compiles successfully. - MUST: OK, there is no locale file in tarball - MUST: OK, no shared library and no ldconfig - MUST: OK, package is not relocatable. - MUST: OK, owns all directories. - MUST: OK, does not contain any duplicate files. - MUST: OK, permissions are correct. - MUST: OK, has %clean - MUST: OK, permissions are correct. - MUST: OK, no need for a seperate doc package. - MUST: OK, no need for -devel and -static packages. - MUST: OK, no .pc files. - MUST: OK, no libtool archives. - MUST: OK, not a gui app. - MUST: OK, package has rm -rf $RPM_BUILD_ROOT at the beginning of %install. - MUST: OK, filenames are valid UTF-8 - MUST: NOT CHECKED (Package must compile in mock) Should fixes: - SHOULD: Remove all whitespaces and use tabs (not necesarry, though. Must fixes: - MUST: FIX: rpmlint throws error about wrong license, you need to fix it. - MUST: FIX: You must define a macro for Business-CreditCard, and call that macro inside the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review