https://bugzilla.redhat.com/show_bug.cgi?id=1298251 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 links are usable. Ok. Source is original (SHA-256: d68561bd674847d6b73961af571adf5720c9b525720afc399c3f7324d7af638f). Ok. The summary is Ok. TODO: I would improve the description a little bit. I would spell "filesize" as two words "file size". I think the second sentence "Inspired by some code found in an OpenOffice Python script (I think)" is irrelevant and I would remove it. Also I think "72dpi" is spelled wrongly. I'd write it as "72 DPI". License verified from shrinkpdf.sh. Ok. No compiled code. noarch BuildArch is Ok. FIX: Run-require "coreutils" because the script executes "cp", "wc", and "cut" programs. FIX: Build-require "coreutils" (shrinkpdf.spec:30). $ rpmlint shrinkpdf.spec ../SRPMS/shrinkpdf-0-1.fc24.src.rpm ../RPMS/noarch/shrinkpdf-0-1.fc24.noarch.rpm shrinkpdf.src: W: spelling-error %description -l en_US filesize -> file size, file-size, fissile shrinkpdf.src: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy shrinkpdf.src: W: spelling-error %description -l en_US recompression -> decompression, re compression, re-compression shrinkpdf.src: W: spelling-error %description -l en_US downsampling -> down sampling, down-sampling, oversampling shrinkpdf.noarch: W: spelling-error %description -l en_US filesize -> file size, file-size, fissile shrinkpdf.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy shrinkpdf.noarch: W: spelling-error %description -l en_US recompression -> decompression, re compression, re-compression shrinkpdf.noarch: W: spelling-error %description -l en_US downsampling -> down sampling, down-sampling, oversampling shrinkpdf.noarch: W: no-documentation shrinkpdf.noarch: W: no-manual-page-for-binary shrinkpdf 2 packages and 1 specfiles checked; 0 errors, 10 warnings. FIX: Correct the "filesize" spelling. $ rpm -q -lv -p ../RPMS/noarch/shrinkpdf-0-1.fc24.noarch.rpm -rwxr-xr-x 1 root root 2979 Feb 2 16:17 /usr/bin/shrinkpdf File permission and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/shrinkpdf-0-1.fc24.noarch.rpm | sort -f | uniq -c 1 /bin/sh 1 ghostscript-core 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require "coreutils". $ rpm -q --provides -p ../RPMS/noarch/shrinkpdf-0-1.fc24.noarch.rpm | sort -f | uniq -c 1 shrinkpdf = 0-1.fc24 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/shrinkpdf-0-1.fc24.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=12788562). Ok. Otherwise the package is in line with Fedora packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review