https://bugzilla.redhat.com/show_bug.cgi?id=1301116 Sinny Kumari <ksinny@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ksinny@xxxxxxxxx --- Comment #6 from Sinny Kumari <ksinny@xxxxxxxxx> --- Few comments on latest spec file: * With recent changes in guideline, C application should include compiler used for compilation source. In this case add, BuildRequires: gcc https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires * %install section contains "ldconfig -n $RPM_BUILD_ROOT%{_libdir}", not sure why it is mentioned here? ld cache will already be updated through %post and %postrun section https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#Shared_Libraries * In %file and %file devel section, specifying %defattr(-,root,root) is not required now https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#File_Permissions * LICENSE file is getting installed in both main and devel package. Since, devel package has dependency on main package, removing %license LICENSE from %files devel section will be fine. * Is there any significance of including static library (libcxl.a) in devel package? If yes, static libraries must be packaged in a -static sub-package https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#Packaging_Static_Libraries_2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review