[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #5 from Marcus Karlsson <mk@xxxxxxxxxx> ---
Thanks. I agree with all your suggestions and I've updated the spec to address
them.

Updated spec URL:
https://www.acc.umu.se/~mk/fedora/openshift-restclient-java/openshift-restclient-java.spec
Updated SRPM URL:
https://www.acc.umu.se/~mk/fedora/openshift-restclient-java/openshift-restclient-java-3.0.1-1.fc24.src.rpm
Updated Koji build URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=12763777

Here is a diff of the spec file from the original version:

--- SPECS/openshift-restclient-java.spec.old    2016-01-31 19:25:16.342412006
+0100
+++ SPECS/openshift-restclient-java.spec    2016-01-31 19:32:33.512994198 +0100
@@ -12,16 +12,19 @@
 BuildArch:      noarch

 BuildRequires: maven-local
-BuildRequires: jsch
+BuildRequires: mvn(com.jcraft:jsch)
+BuildRequires: mvn(commons-codec:commons-codec)
+BuildRequires: mvn(commons-io:commons-io)
+BuildRequires: mvn(commons-lang:commons-lang)
+BuildRequires: mvn(junit:junit)
+BuildRequires: mvn(log4j:log4j)
+BuildRequires: mvn(org.apache.commons:commons-compress)
+BuildRequires: mvn(org.apache.httpcomponents:httpclient)
+BuildRequires: mvn(org.apache.httpcomponents:httpcore)
 BuildRequires: mvn(org.jboss:jboss-dmr)
 BuildRequires: mvn(org.mockito:mockito-core)
-BuildRequires: mvn(junit:junit)
+BuildRequires: mvn(org.slf4j:slf4j-api)
 BuildRequires: mvn(org.slf4j:slf4j-log4j12)
-BuildRequires: mvn(log4j:log4j)
-BuildRequires: mvn(org.codehaus.mojo:properties-maven-plugin)
-BuildRequires: mvn(commons-io:commons-io)
-BuildRequires: mvn(org.apache.maven.plugins:maven-resources-plugin)
-Requires: jsch

 %description
 This is the Java REST client for the version 3 architecture of OpenShift based
@@ -38,7 +41,7 @@

 %prep
 %setup -qn %{name}-%{name}-%{version}.%{rls_tag}
-chmod -x license
+chmod -x license README.md

 %pom_remove_dep org.easytesting:fest-assert

@@ -52,11 +55,11 @@

 %files -f .mfiles
 %dir %{_javadir}/%{name}
-%license epl-v10.html
-%doc license
+%license epl-v10.html license
+%doc README.md DESIGN.md

 %files javadoc -f .mfiles-javadoc
-%license epl-v10.html
+%license epl-v10.html license

 %changelog
 * Sun Jan 10 2016 Marcus Karlsson <mk@xxxxxxxxxx> - 3.0.1-1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]