[Bug 1301589] Review Request: super-csv - A fast, programmer-friendly, free CSV library for Java

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1301589



--- Comment #2 from gil cattaneo <puntogil@xxxxxxxxx> ---
You should use:
fedora-review -b 1301589 --plugins Java -m fedora-rawhide-ARCH
because prevent those problems:

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/java/super-csv,
/usr/share/maven-poms/super-csv
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/maven-poms/super-csv,
/usr/share/java/super-csv

with newer Java tools these directories are already handle (in the generated
files.dir file). If i owned this directory would be created only duplicate
files in rpm

[!]: License file installed when any subpackage combination is installed.
    F.e. installation of super-csv-benchmark does noot trigger it.


[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
super-csv-benchmark, super-csv-dozer, super-csv-java8, super-csv-joda,
super-csv-parent, super-csv-javadoc

Not needed to add extras "Requires: ..." (expecially if are noarch).
These are handled by our Java tools

[!]: %check is present and all tests pass.
Package contains tests. Please run it in %check.

These a maven build style and %check section is unnecessary

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]