[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #2 from Mathieu Bridon <bochecha@xxxxxxxxxxx> ---
hguemar found we seem to be missing a few requirements here, the
requirements.txt file contains:

  requests==2.7.0
  py==1.4.30
  pytest==2.7.3
 
https://github.com/danvk/RangeHTTPServer/tarball/ebb5c5d7af44b3279bdd4b57ddf3093eec3e8794#egg=rangehttpserver
 
https://github.com/JukkaL/mypy/tarball/dcff596be878798fbd43af7b50d95c3eed7ebbc1#egg=mypy-lang

The first one, requests, is already a Requires/BuildRequires in the spec file,
though I didn't specify the version.

The next one, py, is not used at all. It is a dependency of pytest though,
which makes me think this requirements.txt file was generated with "pip
freeze", rather than carefully curated by the author. Which means the versioned
dependencies are probably "whatever was in the virtualenv" rather that trueliy
required versions.

The next one, pytest, is required for the unit tests. As such, I should
definitely add it as a BuildRequires.

And the last one, mypy, is the typing thing from Python 3.5, for older Python
versions. Since I'm only planning on pushing this package in Rawhide, which has
Python 3.5, then this dependency is unnecessary.

Finally, there is the case of rangehttpserver, which is required for the tests,
and therefore should be a BuildRequires.

In summary, I need to add to this package:

  BuildRequires: python3-pytest
  BuildRequires: python3-rangehttpserver

And then change %check to be:

  %check
  py.test-3

I'm going to submit a new Spec/SRPM that does just that.

Unfortunately, rangehttpserver isn't in Fedora yet, so I'll need to submit a
new review request for it.

And in addition, it is not compatible with Python 3 yet:
https://github.com/danvk/RangeHTTPServer/pull/12

So I guess we can leave this review request for the time being, until I get it
all settled.

Sorry for the trouble, and thanks hguemar for the quick comments on IRC!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]