https://bugzilla.redhat.com/show_bug.cgi?id=1300003 David King <amigadave@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |amigadave@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |amigadave@xxxxxxxxxxxxx Flags| |fedora-review? --- Comment #6 from David King <amigadave@xxxxxxxxxxxxx> --- I ran this through fedora-review, and came up with another list of things to fix: * the "Spec URL" should link to the spec file, not a link to a page that shows the spec file (otherwise fedora-review -b <bugnumber> fails) * python-devel should be either python2-devel or python3-devel * the %defattr line in the files section is useless (also, why have an executable desktop file?): https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/thread/KEO7AX3JXR2TY6OVL4M7HDISZ6YIJNKU/ * missing a changelog entry for the 0.7.1-1 release * duplicates in the files list: /var/lib/fleet-commander-admin/profiles * unowned directories: /usr/share/fleet-commander-admin /usr/lib64/fleet-commander/fleetcommander (and several others) * config files need to be marked "noreplace" or clearly marked otherwise * using libdir in a noarch package suggests that the package should not be noarch (probably means that you need to read https://fedoraproject.org/wiki/Packaging:Python#Macros if you haven't already) * the description should be split over multipled lines, and not be one long line There are probably some other things, but fixing those should get me to the next round of fedora-review warnings. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review