https://bugzilla.redhat.com/show_bug.cgi?id=1301748 Patrick Creech <pcreech@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pcreech@xxxxxxxxx | |m) | --- Comment #4 from Patrick Creech <pcreech@xxxxxxxxxx> --- > ===== rbarlow nitpicks ===== > These are optional to fix, but things I recommend. > >[!]: Consider putting two spaces between sections. I.e., add another space > before the %build section so that it's more visually separated. I have added an extra newline between all sections >===== MUST items ===== > >Generic: >[!]: You are depending on rpm-python, but that is not actually the package > you are using. I think you want python-rpm-macros and > python2-rpm-macros instead. You also may not need python2-devel, as > I don't believe there is any C code in here. I switched to python2-rpm-macros instead of rpm-python. I was unable to remove python2-devel, as that was breaking fedora-review. (I assume some macro is defined in there) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review