https://bugzilla.redhat.com/show_bug.cgi?id=1295217 --- Comment #18 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Denis Fateyev from comment #17) > (In reply to Roman Tsisyk from comment #16) > > Is it possible to run the same automated tests before pushing to master? If you submit an update then a bunch of tests are run automatically by Taskotron and they should catch that. > 1) Specfile has invalid name, it shouldn't contain the package version: > http://pkgs.fedoraproject.org/cgit/rpms/msgpuck.git/tree/ > Rpmlint check against SRPM failed; Ooops. > 2) If you use only rhel7 and above, you can drop "%{!?_licensedir" > workaround (I don't see the el6 branch requested); True. > 3) The recent guidelines require to specify all build requirements for new > packages (in your case: make, coreutils, gcc-c++); This changed recently. https://fedorahosted.org/fpc/ticket/490 and https://fedorahosted.org/fpc/ticket/497 have the full history, but the relevant part is the following change to guidelines [https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2]: "It is important that your package list all necessary build dependencies using the BuildRequires?: tag. You may assume that enough of an environment exists for RPM to function and execute basic shell scripts, but you should not assume any other packages are present as RPM dependencies and anything brought into the buildroot by the build system may change over time." fedora-review is wrong here, and one SHOULD have BuildRequires:gcc, though things work just fine without, and will do so for the forseeable future. The spec file is correct. > 4) You can save on '%cmake' options if you use the default options that are > already bootstrapped in epel7 and fXX branches: > $ rpm -E '%cmake' > ... > /usr/bin/cmake \ > -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \ > -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \ > -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \ > -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \ > -DCMAKE_INSTALL_PREFIX:PATH=/usr \ > -DINCLUDE_INSTALL_DIR:PATH=/usr/include \ > -DLIB_INSTALL_DIR:PATH=/usr/lib64 \ > ... > You may use them in `msgpuck` instead of CMAKE_INSTALL_LIBDIR and > CMAKE_INSTALL_INCLUDEDIR; > > 5) Please use empty lines between changelog entries, although there is no > requirement but it helps reading changelogs. Ack. Apart from 3), those are all very valid comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review