[Bug 1265628] Review Request: dhcpcd - A minimalistic network configuration daemon with DHCP and rdisc support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1265628



--- Comment #27 from Tomas Hozza <thozza@xxxxxxxxxx> ---
- (In reply to Pavel Šimerda (pavlix) from comment #22)
> (In reply to Christopher Meng from comment #12)
> > 3. Make sure you have units for all interfaces / single interface, this
> > means you need to create dhcpcd.service and dhcpcd@.service.
> 
> I'm now only interested in dhcpcd.service for now. Let's talk about it later.

I think you should add also include the template unit for per-interface use for
reasons described in
https://wiki.archlinux.org/index.php/dhcpcd#dhcpcd_and_systemd_network_interfaces

It may not be your intended use-case, but the package will be available for all
users in the distributions, therefore should be usable also for others.


Also "%{_var}/lib/" -> "%{_sharedstatedir}"


I'll add the full review of the latest SRPM shortly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]