[Bug 1301253] Review Request: color - A string colorizer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1301253

Brandon Thomas <bthomaszx@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bthomaszx@xxxxxxxxx



--- Comment #1 from Brandon Thomas <bthomaszx@xxxxxxxxx> ---
This is not an official review, and this does not effect the status of the
review request.
* It looks like a period slipped into the packages Summary.
* I don't believe that Amusements/Games" is a valid group.
* "make %{?_smp_mflags}" can be replaced with "%make_build".
* You don't need to specify the packager.
* You probably want the install and ln command to be in the "%install" section.
* You might want to consider including a change log at the end of your file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]