Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbench - Filesystem load benchmarking tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244936 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-06-20 06:55 EST ------- The rpm macros are not used (like %setup). Any reason why it is so? Maybe you could have a look at the spectemplate in /etc/rpmdevtools/spectemplate-minimal.spec In the same vein, the pushd and popd are unuseful in %build. The install section is wrong, as Parag said. Maybe you could also have a quick look at the FHS http://www.pathname.com/fhs/ Instead of using DESTDIR (which would be more correct but requires interaction with upstream), you could also use %makeinstall (although this is discouraged, it workaround broken makefile here). To keep timestamps, you could use: %makeinstall INSTALLCMD='install -c -p' Also it seems to me that it would be better to patch Makefile.in such that * -DDATADIR=\"$(datadir)\" becomes -DDATADIR=\"$(datadir)/dbench\" * clinet.txt is installed in $(datadir)/dbench * man pages are installed in $(mandir)/man1 Missing something like %doc README COPYING -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review