Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: olpc-logos - olpc-related icons and pictures https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244911 ------- Additional Comments From pertusus@xxxxxxx 2007-06-20 04:54 EST ------- * you should keep the timestamp of the file like install -p -m 644 bootloader/grub-splash.xpm.gz %{buildroot}/boot/grub/splash.xpm.gz * I guess this is only x86 but there is no need for an ifarch because it is olpc only and olpc is only for x86? If it is the case it deserves to be more explicitly said in a comment * there should be a comment explaining the Conflicts/Obsolete/Provides and the intended use of this package. Something along # this package replaces fedora-logos on olpc and contains the # only trademarked image file needed for olpc (the grub splash). # it is not to be installed on a full fedora since it doesn't provide # the artwork needed for the fedora packages. * I am not convinced that the conflicts for old packages make that much sense. I guess these conflicts come from files that were once in these packages but then moved to fedora-logos. However these files are not in olpc-logos. Maybe they could be kept to help having olpc-logos remain similar with fedora-logos. * Maybe the version should be set to 6.0.98 to match the fedora-logos version. Otherwise it cannot be installed along with a recent redhat-artwork. * It is not completly clear to me what provides olpc-logos should have. redhat-logos seems to be a remnant from pre-fedora era. But what fedora-logos and system-logos mean as provides is not clear to me: $ rpm -q --provides fedora-logos redhat-logos = 6.0.98-4.fc8 system-logos = 6.0.98-4.fc8 fedora-logos = 6.0.98-4.fc8 $ repoquery --whatrequires fedora-logos wdm-0:1.28-7.fc7.i386 tn5250-0:0.17.3-14.fc7.i386 crystal-clear-0:20050622-4.fc7.noarch $ repoquery --whatrequires system-logos gdm-1:2.19.3-1.fc8.i386 compiz-0:0.4.0-1.fc8.i386 redhat-artwork-0:7.0.0-10.fc8.i386 grub-0:0.97-13.i386 gnome-session-0:2.19.4-1.fc8.i386 gnome-screensaver-0:2.19.1.1-1.fc8.i386 firstboot-0:1.4.35-3.fc8.noarch rhgb-0:0.17.6-1.fc7.i386 anaconda-0:11.3.0.3-1.i386 Maybe, for now, olpc-logos should not Provides fedora-logos but only system-logos (and redhat-logos if you want). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review