[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
+ latest version
+ license is acceptable
+ license files are present, %license is used
- I'm not convinced that the license is specified correctly
+ provides and requires look sane
+ no scriptlets present or necessary
+ description and name are OK

Appdata file is not present, but I don't think it makes much sense to include
it: this package will be installed as part of the desktop, and is useless
otherwise.

There is a desktop file, maybe add
%check desktop-file-validate ...
?

More of an upstream issue, please notify developers:
DISPLAY= /usr/bin/hawaii-system-preferences
QXcbConnection: Could not connect to display 
Aborted (core dumped)

So the only notable issue is the licensing. Can you clarify which parts in the
binary rpm are under which licenses?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]