[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295217

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #8 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Please add 
Provides: msgpuck-static = %{version}-%{release}
to the devel subpackage
[https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2].

I don't know if you intend to provide an EPEL5 version too. If not, you can
drop the license fallback:
https://lists.fedoraproject.org/archives/list/devel%40lists.fedoraproject.org/message/PTZWPNI4B6Q7XF5X2TQ6GKDKYHZRIKJW/.

+ license is acceptable (BSD)
+ license file is present, %license is used
+ package name is OK
+ latest version
+ builds and installs OK
+ %check is present
+ no scriptlets required or present
+ requires and provides OK (apart from issue above)

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]