[Bug 1300158] Review Request: python-editorconfig - A python based distribution of EditorConfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1300158

Andy Lutomirski <luto@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |luto@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |luto@xxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Andy Lutomirski <luto@xxxxxxxxxx> ---
A few comments:

rm -rf $RPM_BUILD_ROOT: shouldn't be needed

Does a simple:

%py2_install
%py3_install

not work?

You've arranged to produce scripts that use python2.  On Fedora 23 and up,
should it be the other way around?

At the very top:

# sitelib for noarch packages, sitearch for others (remove the unneeded one)

please remove that comment and the sitearch macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]