Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-CGI-FormBuilder - Easily generate and process stateful forms Alias: perl-CGI-FormBuilder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244262 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-20 01:46 EST ------- I note that the description is a bit excessive. Frankly I'd remove everything after the first sentence, but you're the maintainer and so I'll just leave it up to you. The file FormBuilder.pm.orig is a bit odd. It's from the upstream source, but I suspect it's a mistake. Can you check it and remove it if it shouldn't be there? Other than that, everything looks good. Review: * source files match upstream: 45e84b1f39730874b19f5982294abaa335bc7bb43b35a24943b809ea627f3a0c CGI-FormBuilder-3.0501.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK (perhaps a bit long) * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(CGI::FormBuilder) = 3.0501 perl(CGI::FormBuilder::Field) = 3.0501 perl(CGI::FormBuilder::Field::button) = 3.0501 perl(CGI::FormBuilder::Field::checkbox) = 3.0501 perl(CGI::FormBuilder::Field::file) = 3.0501 perl(CGI::FormBuilder::Field::hidden) = 3.0501 perl(CGI::FormBuilder::Field::image) = 3.0501 perl(CGI::FormBuilder::Field::password) = 3.0501 perl(CGI::FormBuilder::Field::radio) = 3.0501 perl(CGI::FormBuilder::Field::select) = 3.0501 perl(CGI::FormBuilder::Field::static) = 3.0501 perl(CGI::FormBuilder::Field::submit) = 3.0501 perl(CGI::FormBuilder::Field::text) = 3.0501 perl(CGI::FormBuilder::Field::textarea) = 3.0501 perl(CGI::FormBuilder::Messages) = 3.0501 perl(CGI::FormBuilder::Messages::__LANG__) = 3.0501 perl(CGI::FormBuilder::Messages::locale) = 3.0501 perl(CGI::FormBuilder::Multi) = 3.0501 perl(CGI::FormBuilder::Source) = 3.0501 perl(CGI::FormBuilder::Source::File) = 3.0501 perl(CGI::FormBuilder::Template) = 3.0501 perl(CGI::FormBuilder::Template::Builtin) = 3.0501 perl(CGI::FormBuilder::Template::Div) = 3.0501 perl(CGI::FormBuilder::Template::Fast) = 3.0501 perl(CGI::FormBuilder::Template::HTML) = 3.0501 perl(CGI::FormBuilder::Template::TT2) = 3.0501 perl(CGI::FormBuilder::Template::Text) = 3.0501 perl(CGI::FormBuilder::Test) = 3.0501 perl(CGI::FormBuilder::Util) = 3.0501 perl-CGI-FormBuilder = 3.0501-3.fc8 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(CGI::FastTemplate) perl(CGI::FormBuilder) perl(CGI::FormBuilder::Field) perl(CGI::FormBuilder::Field::text) perl(CGI::FormBuilder::Messages) perl(CGI::FormBuilder::Util) perl(Carp) perl(Exporter) perl(File::Basename) perl(File::Spec::Functions) perl(HTML::Template) perl(Scalar::Util) perl(Template) perl(Text::Template) perl(base) perl(overload) perl(strict) perl(utf8) perl(warnings) * %check is present and all tests pass: All tests successful. Files=10, Tests=502, 3 wallclock secs ( 2.67 cusr + 0.35 csys = 3.02 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review