https://bugzilla.redhat.com/show_bug.cgi?id=1266429 --- Comment #7 from Jens Petersen <petersen@xxxxxxxxxx> --- Thanks for the helpful review comments. Apologies for neglecting this so long. :-( In the meantime today I just noticed another review is also open (bug 1288649)... anyway I hope we can merge/combine the effort. (In reply to Miroslav Suchý from comment #3) > - ldconfig called in %post and %postun if required. > Note: /sbin/ldconfig not called in cmark-lib Thanks (In reply to Marco Driusso from comment #4) > - instead of the mv workaround for fixing cmake lib64 issue, you may patch > src/CMakeLists.txt by including GNUInstallDirs Thanks for this! I struggled to find such a solution. Including seems to do the right thing. :-) > - you should give a full valid URL in the Source0 tag; (I don't think it is possible for github releases unfortunately: the url and the downloaded filname are different.) > - I would put both the command line binary and the versioned shared lib in > the main package, and leave source headers and unversioned lib in the devel > sub-package, without any lib sub-package; Perhaps you're right - it would make the packaging simpler. I intentionall did it this way though since I wanted to give the option to install without the program. (eg cmake vs cmark: though it is only 5 chars) > - devel package must require the base package (the one containing the > versioned shared lib); moreover, the dependency must be a fully versioned > dependency (since there is also an architecture dependency); Yep > - you should include additional documentation in the main package using %doc > (e.g. the README.md file) in the %files section; Yes, let me put it into the devel subpackage for now. Thanks, these errors should all be fixed in: Spec: http://petersen.fedorapeople.org/reviews/cmark/cmark.spec SRPM: http://petersen.fedorapeople.org/reviews/cmark/cmark-0.23.0-1.fc23.src.rpm (I updated to 0.23.0 since that is the version used in the Haskell library - though 0.24 may also work - upgrading this later should be trivial anyway.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review