https://bugzilla.redhat.com/show_bug.cgi?id=1299843 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #12 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + package builds fine in f24-nodejs4 tag which is going to get merged into f24 soon + Source verified with upstream as (sha256sum) upstream source:1a650a9de86eb1e1e1930812efaa88ef408e67e3017426b6745f66a958f377f0 buffertools-2.1.3.tgz.1 srpm source: 1a650a9de86eb1e1e1930812efaa88ef408e67e3017426b6745f66a958f377f0 buffertools-2.1.3.tgz.1 + License is "ISC" which is valid license and included in LICENSE file. + package follows nodejs packaging guidelines. Suggestions: 1) "%install" line is missing which cause few rpmlint "rpm-buildroot-usage" warnings. Just add that line back. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review