[Bug 1272527] Review Request: python-muranoclient - is a client library for Murano

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1272527

hguemar@xxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(asteroid566@gmail |
                   |.com)                       |
                   |needinfo?(karlthered@gmail. |
                   |com)                        |



--- Comment #10 from hguemar@xxxxxxxxxx ---
Few things:
* no need to duplicate Requires between global namespace (there is no binary
python-muranoclient) and subpackage python2-muranoclient.
* BR could be moved under python2-muranoclient for consistency
* python-argparse is part of python standard library so you can drop the
requires. Moreover no packages provides python3-argparse so it cases
installation failures for python3-argparse
* temporarily disable python3 build as oslo libs do not have python3
subpackages enabled yet.
* more problematic:
$ rpmls results/python2-muranoclient-0.7.2-1.fc23.noarch.rpm | grep bin
lrwxrwxrwx  /usr/bin/muranoclient-3
lrwxrwxrwx  /usr/bin/muranoclient-3.4

I recommend that you put in %install the python2 installation last and that you
explicit name binaries in %files. As OpenStack upstream still uses python2 as
default interpreter, it's still better to keep python2 providing the default
version of the client.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]