https://bugzilla.redhat.com/show_bug.cgi?id=1299305 Bug ID: 1299305 Summary: Review Request: erlang-p1_tls - TLS / SSL native driver for Erlang / Elixir Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: jeremy@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx, rbarlow@xxxxxxxxxx Blocks: 1179216, 1204119 Spec URL: https://jcline.fedorapeople.org/erlang-p1_tls.spec SRPM URL: https://jcline.fedorapeople.org/erlang-p1_tls-1.0.0-1.fc23.src.rpm Description: TLS / SSL native driver for Erlang / Elixir. This is used by ejabberd. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12589002 There are quite a few rpmlint warnings: Rpmlint (installed packages) ---------------------------- erlang-p1_tls.x86_64: W: spelling-error %description -l en_US ejabberd -> jabbered, jabberer, jabber erlang-p1_tls.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so erlang-p1_tls.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so driver_alloc erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so driver_free erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so driver_realloc erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so driver_alloc erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so driver_free erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so set_port_control_flags erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so driver_realloc_binary erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so driver_alloc_binary erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so driver_realloc erlang-p1_tls.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so SSL_CTX_set_cipher_list erlang-p1_tls.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_tls_drv.so SSL_CTX_set_cipher_list erlang-p1_tls.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_sha.so erlang-p1_tls.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_sha.so erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_sha.so enif_inspect_iolist_as_binary erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_sha.so enif_make_binary erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_sha.so enif_make_badarg erlang-p1_tls.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_sha.so enif_alloc_binary erlang-p1_tls.x86_64: W: unused-direct-shlib-dependency /usr/lib64/erlang/lib/p1_tls-1.0.0/priv/lib/p1_sha.so /lib64/libssl.so.10 erlang-p1_tls.x86_64: E: incorrect-fsf-address /usr/share/licenses/erlang-p1_tls/COPYING 1 packages and 0 specfiles checked; 1 errors, 21 warnings. In response to the error I filed https://github.com/processone/tls/issues/15. The crypto-policy-non-compliance-openssl warning should be addressed by my patch. The undefined-non-weak-symbol warnings are present in other packages (https://bugzilla.redhat.com/show_bug.cgi?id=1295009) and it seems that Erlang does the right thing. It is convention to not strip the binaries for erlang. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1179216 [Bug 1179216] Utilize system-wide crypto-policies https://bugzilla.redhat.com/show_bug.cgi?id=1204119 [Bug 1204119] ejabberd-16.01 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review