https://bugzilla.redhat.com/show_bug.cgi?id=1297281 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Oh, a game, nice. Even has appdata, even nicer. In the future, please link to plain text version of the spec file. HTML breaks fedora-review and other automated tools. Requires: %{name}-data → Requires: %{name}-data = %{version}-%{release} You don't want to deal with bug reports from people who upgrade the main package but not the data package, or the other way around. It's best to ensure that they are always in lockstep. You have mixed licensing. You should document the licensing in a comment in the spec file. "cp %{SOURCE1} ." can be replaced with "-a1" argument to %autosetup. Empty %doc in %files data: I don't think this does anything, can be removed. fedora-review says: - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in endless-sky See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. You should also call appstream-util validate-relax --nonet on the appstream file in %check. You should also manually call appstream-util validate by hand, and fix the issues it reports. This is more strict, so you don't want to use it in %check: /usr/share/appdata/endless-sky.appdata.xml: FAILED: • tag-missing : <update_contact> is not present • style-invalid : <caption> is too long [Finding trade routes, made easy: the map view shows commodity prices for other star systems and can color them based on price, to help you decide what trade goods you should buy in the current system for sale elsewhere] • style-invalid : <caption> is too long [Strange discoveries await you beyond the boundaries of known space] • style-invalid : <caption> is too long [You can earn a living just by buying commodities for a low price in one star system and selling them at a profit elsewhere] • style-invalid : <developer_name> is too long [XXX: Insert Company or Developer Name] Validation of files failed I'd be happy to sponsor you into the packagers group. Please do two or three reviews of packages from http://fedoraproject.org/PackageReviewStatus/NEW.html. Running fedora-review is a good first step, but please note that the automatically generated template needs to be filled in in various places, and trimmed in others. Not everything the tools say is always correct. Sometimes they are outdated, sometimes they are plain wrong. It's always best to link to the relevant part of the guidelines. Please pick packages that are in the area you are interested in, so that you can finalize the review after you get the packager bit. If you have any questions or issues, I'll try to help (zbyszek at in waw pl, zbyszek on #fedora-devel). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review