https://bugzilla.redhat.com/show_bug.cgi?id=1294858 Pier Luigi Fiorini <pierluigi.fiorini@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #4 from Pier Luigi Fiorini <pierluigi.fiorini@xxxxxxxxx> --- name: ok source: ok SHA1 2b19fa4fd87e4226c327c6e9c0362d8dc7903654 libkface-15.12.0.tar.xz license: ok post/postun ldconfig: ok filelist: 1. AUTHORS, README and TODO are not %doc (it's #doc) 2. I have an observation regarding subdirs owned by this package, though a lot are done this way. I'm referring to %dir missing for %{_kf5_includedir}/KFace/ and %{_kf5_libdir}/cmake/KF5KFace/ from the devel package Considering that 1 is not a blocker and 2 a lot of packages are done like this: APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review