https://bugzilla.redhat.com/show_bug.cgi?id=1288731 --- Comment #19 from awilliam@xxxxxxxxxx <awilliam@xxxxxxxxxx> --- Oh, now I remember why I had it that way. If you read the wiki page, it tells you to do %{?perl_default_filter} first, then redefine any of the filters you want to override, including the original definition, as per their example: %{?perl_default_filter} %global __requires_exclude perl\\(VMS|perl\\(Win32|my_additional_pattern That's what I was doing. In 4.2 I needed to exclude provides from another file, so the block looked like this: %{?perl_default_filter} %global __requires_exclude_from %{_docdir}|%{_libexecdir}/os-autoinst/autoinstallstep.pm in 4.3, autoinstallstep.pm is gone, so I removed that file from the regex, which just left this: %{?perl_default_filter} %global __requires_exclude_from %{_docdir} which as you pointed out is silly because it's just recreating the definition from perl_default_filter - but now I remember how it got that way. The block you suggest won't work, because %{?perl_default_filter} will just override the __provides_exclude_from and __requires_exclude definitions above it. As per the wiki page we'll have to do perl_default_filter first, then redefine __provides_exclude_from and __requires_exclude, including the default exclusions along with the ones we need. (I just looked into whether my exclude-requires-from-this-file-and-also-dont-generate-provides-for-them idea would work and unfortunately it doesn't look simple, because the generation of provides and requires is done separately and you can't really pass information from one to the other very easily). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review