https://bugzilla.redhat.com/show_bug.cgi?id=1295230 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@xxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok 8e29d8d69bf6ffe04177ad0907f395ff hawaii-workspace-0.5.0.tar.xz licensing: ok files: ok, but 1. the filelist is small, so SHOULD track files more closely instead of using globs everywhere, with something like: %files ... %{_bindir}/hawaii-polkit-agent %{_bindir}/hawaii-screenshot %{_sysconfdir}/xdg/hawaii-polkit-agent.desktop %{_datadir}/applications/org.hawaiios.screenshot.desktop 2. MUST validate all application .desktop files, adding BuildRequires: desktop-file-utils ... %check desktop-file-validate %{buildroot}%{_datadir}/applications/org.hawaiios.screenshot.desktop 3. SHOULD omit deprecated rpm tags Group: All in all, pretty simple and clean, only one mostly-cosmetic MUST blocker (2)... I'll leave it to you to add prior to doing any official builds. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review