https://bugzilla.redhat.com/show_bug.cgi?id=1298665 --- Comment #2 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- Just a few things I noticed (not yet a full review): - You're using too many macros for my taste. Some of them are entirely unused. - Some spec file tags are unnecessary these days (Group, BuildRoot, the %clean step, %defattr). - I don't like messing with limits.conf in %post like that. If you really need to reconfigure the limits, consider shipping a fragment file in /etc/security/limits.d/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review