[Bug 1297704] Review Request: python-cookies - Friendlier RFC 6265-compliant cookie parser/renderer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1297704



--- Comment #9 from Germano Massullo <germano.massullo@xxxxxxxxx> ---
(In reply to Fabio Alessandro Locati from comment #7)
> Ok, here we are!
> 
> So, starting from the previous points, ok on all of them (the point 1 raised
> a flag since the file was not deletef due to 2, so fixind 2 makes 1
> pointless, as you pointed out).
> 
> I think we are pretty close to the approval, few changes are still needed:
> 
> 1. I would use https://gitlab.com/sashahart/cookies/raw/master/LICENSE as
> Source1
> 
> 2. You have to delete the shipped egg folder (rm -rf %{pypi_name}.egg-info)
> in %prep
> 
> 3. The %shangelog area has to be filled

==== STATUS AND COMMENTS ====

1. DONE

2. REJECTED
(In reply to Kevin Kofler from comment #8)
> > 2. You have to delete the shipped egg folder (rm -rf %{pypi_name}.egg-info) in %prep
> 
> No. egg-info should NOT be deleted anymore. (This changed years ago!)

3. DONE

All changes are available at

https://fedorapeople.org/~germano/package_reviews/python-cookies/fixed_files_after_review/python-cookies.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]