[Bug 1297552] Review Request: atomic-devmode - Try out Atomic Host without cloud-init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1297552



--- Comment #11 from Jonathan Lebon <jlebon@xxxxxxxxxx> ---
Updated:

Homepage: https://github.com/jlebon/atomic-devmode
Spec URL: https://jlebon.fedorapeople.org/atomic-devmode.spec
SRPM URL: https://jlebon.fedorapeople.org/atomic-devmode-0.2-1.fc23.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12550898

---

(In reply to Patrick Uiterwijk from comment #7)
> Issues:
> - License is a very old one (Library GPL, which is superseded by Lesser GPL)

Fixed! (Updated to LGPLGv3+)

> - COPYING is not installed

Fixed!

> - Using both %-style macros and $-style variables

Fixed!

> - Package contains a lot of files that don't currenlty conflict, but sound
>   like they will very likely conflict easily

This was a misunderstanding. Should be fine.

> - Hardcoded paths used (%_prefix}/lib vs %{_libdir})

Fixed!

> - No %build section

Fixed!

> - No documentation

Fixed!

> Rpmlint
> -------
> Checking: atomic-devmode-0.1-1.fc21.x86_64.rpm
>           atomic-devmode-0.1-1.fc21.src.rpm
> atomic-devmode.x86_64: E: explicit-lib-dependency libpwquality

This is an issue with the libpwquality package, which contains the
/usr/bin/pwmake binary, which my scripts require.

> atomic-devmode.x86_64: E: no-binary

Fixed!

> atomic-devmode.x86_64: W: only-non-binary-in-usr-lib

Fixed!

> atomic-devmode.x86_64: W: no-documentation

Fixed!

> atomic-devmode.src: W: spelling-error %description -l en_US init -> unit,
> int, nit

Not a typo. The name of the package mentioned is "cloud-init".

> atomic-devmode.src:32: E: hardcoded-library-path in
> %{_prefix}/lib/atomic-devmode

Fixed!

> atomic-devmode.src: W: no-%build-section

Fixed!

> atomic-devmode.src: W: invalid-url Source0: atomic-devmode.tar.gz

I provide instructions right above this line for how to obtain the archive:

---
# From `make archive REF=v${VERSION}`
---

(In reply to Patrick Uiterwijk from comment #8)
> Oh, and you should mark the package as noarch probably, since I odn't think
> there's anything archful in there.

Done!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]