Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: yum-cron - get yum updates via a cron job https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244894 ------- Additional Comments From ahabig@xxxxxxx 2007-06-19 16:38 EST ------- Thanks for the review! Updated: Spec URL: http://neutrino.d.umn.edu/~habig/yum-cron.spec SRPM URL: http://neutrino.d.umn.edu/~habig/yum-cron-0.2-3.src.rpm Questions: 1) /etc/yum/yum-daily.yum is not really a config file, it's the commands given to yum. So, a script, albeit not a bash or perl script, and not executable. So, I think we do want it replaced, as it's code not configurations. Is there a file class that's not an executable but not a config file which I should be using instead? Just leaving it unlabeled gets rpmlint grumpy since it's in /etc. 2) The only starting of the "service" now is done in %postun if "$1" -ge "1" (there's been an upgrade), and that's a conditional restart. So I think that's now meets standards. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review