https://bugzilla.redhat.com/show_bug.cgi?id=1259486 --- Comment #7 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) First thx for your comment, I will try to fix some next week. > Why not use a tarball directly from github, and run autogen.sh during There is no tagged release yet, so I'm re-using the usual snapshot method instead. > make %{?_smp_mflags} V=1 → %make_build V=1 What the main interest of this change ? > find %{buildroot} -name '*.la' -exec rm -f {} ';' → find %{buildroot} -name > '*.la' -delete > > (-f is bad, because it means "ignore errors", and if an error happened here, > you actually want the build to fail. Anyway -delete is nicer.) We don't want to deal with installed .la files. And they won't disappear. But either they are here or not by default, it doesn't matter: we want them out! Also, we don't want the build to fail for any reason related to la files. So I think it's on purpose. > No %license file? > No %check? I will check. Do you have any others comments? Is this a full review? Can you take-over as a reviewer ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review