https://bugzilla.redhat.com/show_bug.cgi?id=1297704 Fabio Alessandro Locati <fabio@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabio@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |fabio@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Fabio Alessandro Locati <fabio@xxxxxxxxx> --- Let's start with some small things to fix and then we'll move to the formal review as soon as those small things are out of the way. 0. (not for review, but future reviews) please don't link github webpages but real files because linking to github HTML pages breaks fedora-review 1. test_cookies.py is 644 but has shabang. One of the two has to be changed (probably the former) 2. You remove test_cookied.py in the %check section. This is wrong and does not make any sense. You can do it in %prep if you want to remove it before compiling or in %install (after %pyX_build) if you want to remove it after compiling 3. Do you want to be able to package it under EL? If yes, it will not work as it is now because EL does not have python3, %py2_build, and %py2_install 4. Please use "BuildRequires: python2-devel" instead of "BuildRequires: python-devel" 5. Please include the LICENSE file. If it's not provided directly by the package, use an external source -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review