[Bug 1290524] Review Request: libdkimpp - Lightweight and portable DKIM (RFC4871) library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1290524



--- Comment #5 from Denis Fateyev <denis@xxxxxxxxxxx> ---
Thanks for the review. I'll look at libpwiz shortly.

> - All build dependencies are listed in BuildRequires, except for any that
>  are listed in the exceptions section of Packaging Guidelines.
>  Note: These BR are not needed: coreutils make gcc-c++
>  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

Due to the latest version of the packaging guidelines, all dependencies should
be listed, the exception list is gone. For more info:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2
https://fedorahosted.org/fpc/ticket/497

> - 'Full Relro' feature is not mandatory for libraries on EPEL; this is
>  just for info:
>
>  'Partial Relro' warning of 'libdkim++.so.1.0.8' in the EPEL7 build.
>  https://fedoraproject.org/wiki/Changes/Harden_All_Packages

I can't reproduce this with rpmlint, could you get more info where you can see
this? I'll add `_hardened_build` to the spec, anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]