Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: msmtp - an SMTP client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243631 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-06-19 10:20 EST ------- Please use http://downloads.sf.net in the URL for Source0. It it much more reliable and scripting friendly then http://dl.sf.net According to the source, you do not need to BR both gnutls-devel and openssl-devel, either one would suffice. On the other hand, in order to build translations, please add a BuildRequires for gettext. It would also be wise to buildrequire cyrus-sasl-devel, in order to include gnu-sasl support. Otherwise the configure script will say: checking for libgsasl... no configure: WARNING: Cannot find GNU SASL, disabling In order to use the package as a drop-in replacement for sendmail, I suggest adding the following Provides: /usr/bin/sendmail and MTA. In this case you should also add a couple of scriptlets to handle the install/remove of this package via the alternatives system. It's up to you to decide if you want to replace sendmail or just coexist with it. Otherwise the package is in excellent shape and I will do a full review shortly. Note that I cannot sponsor you, so this will not be enough to have the package included. Which is also the reason I will not assign the review to myself. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review