https://bugzilla.redhat.com/show_bug.cgi?id=1297347 --- Comment #1 from Pavel Raiskup <praiskup@xxxxxxxxxx> --- My major concern to ask for edit is to fix the packaging of license file which is available in tarball. See also the one trailing whitespace and mixed-use-of-space-and-tabs catched by rpmlint. Shortened fedora-review output: ===== MUST items ===== Generic: [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License file installed when any subpackage combination is installed. [!]: Package complies to the Packaging Guidelines ===== SHOULD items ===== Generic: [?]: Package functions as described. praiskup: I'll test with 'postgresql-jdbc' build once Pavel gives me a patch. [!]: %check is present and all tests pass. praiskup: there seem to be testsuite within the pom.xml, if that is truth - could we nable it? ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. attachments: java-comment-preprocessor.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 1) 3 packages and 0 specfiles checked; 0 errors, 7 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review