https://bugzilla.redhat.com/show_bug.cgi?id=1297274 Bug ID: 1297274 Summary: Review Request: pulp - An application for managing software repositories Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: rbarlow@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: https://rbarlow.fedorapeople.org/pulp.spec SRPM URL: https://rbarlow.fedorapeople.org/pulp-2.8.0-0.1.alpha.20160110gitb5031a23.fc24.src.rpm Description: Pulp provides replication, access, and accounting for software repositories. Fedora Account System Username: rbarlow Known rpmlint issues, with inline comments: pulp-admin-client.noarch: W: conffile-without-noreplace-flag /etc/bash_completion.d/pulp-admin pulp-consumer-client.noarch: W: conffile-without-noreplace-flag /etc/bash_completion.d/pulp-consumer IMO, bash_completions shouldn't have noreplace. Is that correct? pulp-agent.noarch: E: zero-length /etc/pulp/agent/agent.conf I filed this upstream: https://pulp.plan.io/issues/1497 pulp-consumer-client.noarch: E: non-readable /etc/pki/pulp/consumer/rsa.key 640 pulp-nodes-child.noarch: E: non-readable /etc/pulp/server/plugins.conf.d/nodes/importer/http.conf 640 pulp-nodes-common.noarch: E: non-readable /etc/pulp/nodes.conf 640 pulp-server.noarch: E: non-readable /etc/pki/pulp/rsa.key 640 pulp-server.noarch: E: non-readable /etc/pulp/server.conf 640 pulp-server.noarch: E: non-readable /etc/pki/pulp/ca.key 640 These config files all contains secrets (secret keys or passwords) and so shouldn't be world-readable. pulp-nodes-common.noarch: W: no-manual-page-for-binary pulp-gen-nodes-certificate pulp-server.noarch: W: no-manual-page-for-binary pulp-gen-ca-certificate pulp-server.noarch: W: no-manual-page-for-binary pulp-manage-db pulp-server.noarch: W: no-manual-page-for-binary pulp-qpid-ssl-cfg I filed an issue for these upstream: https://pulp.plan.io/issues/1499 pulp-nodes-parent.noarch: W: dangling-symlink /var/www/pulp/nodes/content /var/lib/pulp/content This one I'm not sure about. pulp-nodes installs this symlinks, but the destination is into pulp-server which is a dependency. I'd think that would be OK, but rpmlint is upset. pulp-server.noarch: E: explicit-lib-dependency python-httplib2 I think rpmlint is in error here, as this is a Python package, not a C library. pulp-server.noarch: E: non-standard-dir-perm /var/log/pulp 750 The logs might contain secret information from time to time, so we have decided to make them secret. Is this OK? pulp-server.noarch: W: log-files-without-logrotate ['/var/log/pulp'] I've filed this issue upstream: https://pulp.plan.io/issues/1498 python2-pulp-streamer.noarch: W: empty-%postun 19 packages and 0 specfiles checked; 9 errors, 9 warnings. In full disclosure, I have not tested the functionality of these packages. Pulp by itself has no functionality - it needs at least one plugin to be able to "do" anything. Unfortunately, each plugin has a dependency on the platform package, and so there is a chicken-and-egg situation. My plan is to get platform into Rawhide, and then use pulp-docker as a test package to refine it (if there are issues) when I submit a package request for pulp-docker next. If preferred, I may be able to do some of the testing with pulp-docker as I work on it, before we move Pulp platform into Rawhide (though I won't be able to use fedora-review on pulp-docker without Pulp platform being included in Rawhide). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review