https://bugzilla.redhat.com/show_bug.cgi?id=1271379 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Summary should not repeat the name. Something like this instead: Summary: Direct execution of SQL-like queries on tabular text files Don't gzip the man page. It will be done automatically by rpm. Also use q-test-as-data.1.* in %files (not .gz), so there is no need to adjust if the compression scheme ever changes. Why 'rm -f'? The removal should not fail under any circumstances, so plain 'rm' should be used. You have with_python3 defined, but it is not used anywhere. Does the program support python3? If yes, then it should run under python3. Independently of whether python2 or python3 is used, the shebang line should be changed from /usr/bin/env... to /usr/bin/python2 or /usr/bin/python3. Try: sed -i '1s/#!.*/#!%{__python2}/' FILENAME -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review