[Bug 1294211] Review Request: marble-widget - Marble Widget Library for Qt4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1294211



--- Comment #11 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
https://rdieter.fedorapeople.org/rpms/marble-widget/marble-widget.spec
https://rdieter.fedorapeople.org/rpms/marble-widget/marble-widget-15.08.3-51.fc23.src.rpm

%changelog
* Sun Jan 10 2016 Rex Dieter <rdieter@xxxxxxxxxxxxxxxxx> 1:15.08.3-51
- %%license LICENSE.txt
- remove reference to unused marble-data subpkg
- -devel: Conflicts: marble-widget-qt5-devel
- update URL, simplify Source0 URL

For remaining questions:

- Do we expect upstream to accept still those patches for the qt4 branch?

I have upstream commit access and strictly the older branches are not closed,
but since there's going to be no new releases based on this branch, upstreaming
anything isn't very helpful.

- Maybe add a comment about the discontinued qt4 branch

a .spec comment?  Maybe for posterity, but our current maintainers are well
aware of the situation.


- Subpackage widget-data exists in both marble-widget.spec and marble.spec
files. How to difference between both with different versions (15.08.3 vs.
15.12.0)? Do you really want to name it marble-widget-widget-data (mind twice
widget) in case of marble-widget.spec? That can not work with Requires: 
%{name}-data . There's no %files widget-data in marble-widget.spec, so I guess
it's just a copy-paste error somehow?

This package does not produce any widget-data subpkg, but there was an
extraneous 
%package widget-data
reference which is now removed.

- Why exclude astro as it has been activated in the old subpackage from
marble.spec? Is that a plugin and now obsolete?

Using system astro (from main marble package), see
BuildRequires: marble-astro-devel

- The mobile switch gets turned ON in marble-widget.spec but it was OFF in
marble.spec?

All apps are already disabled from building, no need to explicitly exlude it
(again).  We're only building libmarble

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]