https://bugzilla.redhat.com/show_bug.cgi?id=1251689 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from gil cattaneo <puntogil@xxxxxxxxx> --- NON blocking issues: you should use %global commit0 0675236370458e819ee21e4427c5f7f3f9485d33 Source0: https://github.com/wg/scrypt/archive/%{commit0}.tar.gz https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services %doc README should be removed in javadoc sub package Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review