[Bug 1294211] Review Request: marble-widget - Marble Widget Library for Qt4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1294211

Raphael Groner <projects.rg@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |projects.rg@xxxxxxxx
              Flags|                            |fedora-review?



--- Comment #9 from Raphael Groner <projects.rg@xxxxxxxx> ---
- as stated on the old one. Please update URL.
"The Marble website has moved to marble.kde.org"

- Do you mean stable instead of unstable?
"The requested URL /unstable/applications/15.08.3/src/marble-15.08.3.tar.xz was
not found on this server."

- Do we expect upstream to accept still those patches for the qt4 branch?

- Maybe add a comment about the discontinued qt4 branch, so we don't confuse
with a further update that happens for Qt5 only in the separated marble main
package.

- Subpackage widget-data exists in both marble-widget.spec and marble.spec
files. How to difference between both with different versions (15.08.3 vs.
15.12.0)? Do you really want to name it marble-widget-widget-data (mind twice
widget) in case of marble-widget.spec? That can not work with Requires: 
%{name}-data . There's no %files widget-data in marble-widget.spec, so I guess
it's just a copy-paste error somehow?

- Why exclude astro as it has been activated in the old subpackage from
marble.spec? Is that a plugin and now obsolete?
>  -DBUILD_MARBLE_PLUGINS:BOOL=OFF

- The mobile switch gets turned ON in marble-widget.spec but it was OFF in
marble.spec?
>  -DMOBILE:BOOL=OFF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]