https://bugzilla.redhat.com/show_bug.cgi?id=1293100 --- Comment #15 from Roman Tsisyk <roman@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #13) Thanks you for you review! > %global __strip /bin/true might work. Sorry, this hack doesn't work for me :( > Don't repeat the package name in Summary. Also don't use the article, it > looks bad in listings: > > Summary: In-memory database and Lua application server Fixed. > Remove Vendor tag. Fixed. > > Why do you need explicit requirements on readline and other libraries; > aren't the automatically generated dependencies enough? Fixed. > > Development subpackage should be called devel, that's the Fedora standard. Fixed. > tarantool should requires te same version of tarantool-common: > Requires: %{name}-common = %{version}-%{release} > Most likely you do not need the Requires on tarantool in tarantool-common. tarantool-common provides /usr/bin/tarantoolctl script which uses /usr/bin/tarantool to operate. The idea was to have common init scripts and management tools for multiple versions of tarantool. > %if 1%{?systemd} → this condition is always true. Maybe you meant %if > 0%{?systemd}? Fixed. > What's with the quotes around filenames in %files? This is an old shell habit. Fixed. > Scripts in %post should never fail, add || : everywhere. I moved %post scripts to %install and %files Changelog: +- Rename tarantool-dev to tarantool-devel +- Remove Vendor +- Remove quotes from %files +- Disable hardening to fix backtraces +- Fix permissions for tarantoolctl directories +- Comply with http://fedoraproject.org/wiki/Packaging:DistTag +- Comply with http://fedoraproject.org/wiki/Packaging:LicensingGuidelines +- Comply with http://fedoraproject.org/wiki/Packaging:Tmpfiles.d +- Comply with the policy for log files +- Comply with the policy for man pages +- Other changes according to #1293100 review Spec URL: https://gist.githubusercontent.com/rtsisyk/8a8d2dcae143d0699e76/raw/84b92b205f60c545244d191f5931cb1195208a71/tarantool_1.6.8.294.spec SRPM URL: https://gist.github.com/rtsisyk/8a8d2dcae143d0699e76/raw/84b92b205f60c545244d191f5931cb1195208a71/tarantool-1.6.8.294-1.fc24.src.rpm Buildbot: http://koji.fedoraproject.org/koji/taskinfo?taskID=12483677 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review