https://bugzilla.redhat.com/show_bug.cgi?id=1295075 Randy Barlow <rbarlow@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jeremy@xxxxxxxxxx | |) --- Comment #6 from Randy Barlow <rbarlow@xxxxxxxxxx> --- This package fails to install, due to a typo on a Requires. It requires erlang-ert, but the package is actually called erlang-erts. FWIW, this package is also depending on erlang-p1_utils, which already depends on erlang-erts so IMO it's probably OK for you to not also depend on erts unless you want to. It's your call. It's tricky to do much more review like this though. I also noticed that you didn't have a BuildRequires on erlang-eunit, but I guess somehow that's OK because your build does work. I had been listing that as a BuildRequires on mine but maybe something else is bringing that in? Another note - I just noticed that the erlang macros have these: %_erldir %{_libdir}/erlang %_erllibdir %{_erldir}/lib Perhaps we should both be using these? I wouldn't consider it a blocker, but it does seem like a good idea. Sadly, none of my packages use them, womp womp. FYI, you can see the macros at /usr/lib/rpm/macros.d/macros.erlang. I suspect we also need the provides requires stuff (maybe then we don't need erts explicitly?) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review