Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libgii - General Graphics Interface toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239939 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora ------- Additional Comments From matthias@xxxxxxxxxxxx 2007-06-19 05:40 EST ------- Looking good! :-) Minor : - Why is ChangeLog.1999 back? It doesn't want to die? ;-) - Why not just use a single "%{_includedir}/ggi/" line for the headers in devel? (you already use a single "%{_libdir}/ggi/" line in the main package) - Maybe it could be interesting to split out the binaries and man1 pages into a libggi-utils sub-package? (not sure what the policy is for this, but it might be a good thing regarding multilib for instance) Major : - The man3 pages should go into the devel package. Only man1 and man7 in main. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review